hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz" <leftylever...@gmail.com>
Subject Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into HiveConf and document the settings
Date Tue, 01 Dec 2015 08:34:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/#review108464
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2442 - 2446)
<https://reviews.apache.org/r/40365/#comment167922>

    ">0" got dropped -- add it before "indicates a specific bound."



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2460 - 2470)
<https://reviews.apache.org/r/40365/#comment167924>

    [..].connection.timeout.ms:  Is "before" correct in "before a failure" or should it be
"Timeout (in milliseconds) after a connection failure ..."?
    
    Hm, I must be confused because the next parameter seems to cover that case -- [..].sleep.between.retries.


- Lefty Leverenz


On Nov. 23, 2015, 9:41 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40365/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 9:41 p.m.)
> 
> 
> Review request for hive, Lefty Leverenz and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f48403b 
>   data/conf/llap/llap-daemon-site.xml f2851a7 
>   llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java
bd09024 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
34e0682 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
a8e1465 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java
d474b6f 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
4b28b53 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java
bc18a77 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java
9520413 
>   llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
d327fc0 
>   llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c

>   llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86

>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9

>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java
8d45c95 
>   llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4

> 
> Diff: https://reviews.apache.org/r/40365/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message