Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CAD1117975 for ; Tue, 17 Nov 2015 11:22:13 +0000 (UTC) Received: (qmail 26592 invoked by uid 500); 17 Nov 2015 11:22:13 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 26525 invoked by uid 500); 17 Nov 2015 11:22:13 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 26179 invoked by uid 99); 17 Nov 2015 11:22:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 11:22:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D78A52C97AF; Tue, 17 Nov 2015 11:22:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1682654679425802380==" MIME-Version: 1.0 Subject: Re: Review Request 40344: HIVE-6113 Unable to instantiate org.apache.hadoop.hive.metastore.HiveMetaStoreClient From: "Oleksiy Sayankin" To: "hive" , "Oleksiy Sayankin" Date: Tue, 17 Nov 2015 11:22:11 -0000 Message-ID: <20151117112211.19610.74696@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Oleksiy Sayankin" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40344/ X-Sender: "Oleksiy Sayankin" References: <20151116124437.19610.28614@reviews.apache.org> In-Reply-To: <20151116124437.19610.28614@reviews.apache.org> Reply-To: "Oleksiy Sayankin" X-ReviewRequest-Repository: hive-git --===============1682654679425802380== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40344/ ----------------------------------------------------------- (Updated Nov. 17, 2015, 11:22 a.m.) Review request for hive. Changes ------- Code change summary. Renamed: datanucleus.validateTables ---> datanucleus.schema.validateTables datanucleus.validateColumns ---> datanucleus.schema.validateColumns datanucleus.validateConstraints ---> datanucleus.schema.validateConstraints datanucleus.autoCreateSchema ---> datanucleus.schema.autoCreateAll Deleted: datanucleus.fixedDatastore Repository: hive-git Description ------- Bugs in DataNucleus and MySQL Connector! Any Hive user will potentially hit the problem. My SELECT query got incorrect results because JDOQLQuery.compileQueryFull swallowed the fatal datastore exception when it called RDBMSQueryUtils.getStatementForCandidates. This is a bug in RDBMSQueryUtils.getStatementForCandidates or its caller(s). Diffs (updated) ----- beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java 21ba690 beeline/src/test/resources/hive-site.xml b2347c7 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 425c7d9 data/conf/hive-site.xml d15cc17 data/conf/llap/hive-site.xml becb5b2 data/conf/spark/standalone/hive-site.xml 38d0832 data/conf/spark/yarn-client/hive-site.xml ada3f3b data/conf/tez/hive-site.xml d008ad1 hcatalog/src/test/e2e/templeton/deployers/config/hive/hive-site.mssql.xml 8473d99 hcatalog/src/test/e2e/templeton/deployers/config/hive/hive-site.mysql.xml b6f1ab7 metastore/scripts/upgrade/mssql/README 8e5a33e pom.xml 4a90cef ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java de2eb98 Diff: https://reviews.apache.org/r/40344/diff/ Testing ------- Thanks, Oleksiy Sayankin --===============1682654679425802380==--