hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang" <ctang...@gmail.com>
Subject Review Request 40785: HIVE-12506: SHOW CREATE TABLE command creates a table that does not work for RCFile format
Date Sun, 29 Nov 2015 17:47:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40785/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

More than one SerDe in Hive (e.g. LazySimpleSerDe, ColumnarSerDe) use the DELIMITED properties,
so "show create table" output with DELIMTED instead of SERDE [WITH SERDEPROPERTIES] is not
sufficient to be used to recreate the same table.


Diffs
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 02cbd76 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a210b95 
  ql/src/test/results/clientpositive/nullformat.q.out 6cfc2b8 
  ql/src/test/results/clientpositive/nullformatCTAS.q.out 7adca68 
  ql/src/test/results/clientpositive/show_create_table_delimited.q.out 79f29de 

Diff: https://reviews.apache.org/r/40785/diff/


Testing
-------

1. Manual tests passed
2. has been submitted for pre-commit build.


Thanks,

Chaoyu Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message