hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang" <jxi...@apache.org>
Subject Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Date Fri, 20 Nov 2015 17:09:03 GMT


> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > LGTM. This patch only includes SQLOperations. Are we planning to add metadata operations
as well ? (so we can capture jdbc clients and Hue usage as well...)

Thanks a lot for the review. I was thinking about showing meta operations in HMS web UI. Should
we also show them here?


> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1856
> > <https://reviews.apache.org/r/40500/diff/1/?file=1133028#file1133028line1856>
> >
> >     Th -> The

Good catch. Fixed.


> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java, line
66
> > <https://reviews.apache.org/r/40500/diff/1/?file=1133036#file1133036line66>
> >
> >     any reason we only want sqloperations ?

No special reason. SQLOperations are interesting to show for HS2. Hive commands are quick
to run. Meta operations, should we show them in HMS web ui?


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107283
-----------------------------------------------------------


On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 8:53 p.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12338
>     https://issues.apache.org/jira/browse/HIVE-12338
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently
it shows active sessions and queries. It can also access locals, metrics, and configuration.
> 
> 
> Diffs
> -----
> 
>   common/pom.xml cd14581 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85 
>   common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION 
>   common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION 
>   common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION 
>   common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION 
>   pom.xml c6df4a5 
>   service/pom.xml afa52cf 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e 
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351

>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2 
>   service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION 
>   service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION 
>   service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION

>   service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION 
>   service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION 
>   service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION

>   service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION

>   service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION

>   service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION

>   service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40500/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message