hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz" <leftylever...@gmail.com>
Subject Re: Review Request 39333: HIVE-11777 implement an option to have single ETL strategy for multiple directories
Date Tue, 03 Nov 2015 08:38:43 GMT


> On Oct. 15, 2015, 6:39 a.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 1092-1093
> > <https://reviews.apache.org/r/39333/diff/1/?file=1098682#file1098682line1092>
> >
> >     Please fix the typo "geneation" and elaborate on "0 means don't" -- don't wait
or don't batch?
> >     
> >     If ms means the units are milliseconds, please say so in the description.  Shouldn't
this use a TimeValidator as in hive.stats.retries.wait and others?

Looks good, thanks for the changes.


- Lefty


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39333/#review102762
-----------------------------------------------------------


On Nov. 2, 2015, 11:56 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39333/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 11:56 p.m.)
> 
> 
> Review request for hive, Gopal V and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java af40137 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java c61d615 
> 
> Diff: https://reviews.apache.org/r/39333/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message