Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57BB7186B6 for ; Fri, 23 Oct 2015 04:56:17 +0000 (UTC) Received: (qmail 911 invoked by uid 500); 23 Oct 2015 04:56:17 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 836 invoked by uid 500); 23 Oct 2015 04:56:16 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 822 invoked by uid 99); 23 Oct 2015 04:56:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2015 04:56:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 23CE5278E24; Fri, 23 Oct 2015 04:56:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7742597553157179951==" MIME-Version: 1.0 Subject: Re: Review Request 38211: HIVE-11684 From: "John Pullokkaran" To: "John Pullokkaran" Cc: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= , hive Date: Fri, 23 Oct 2015 04:56:16 -0000 Message-ID: <20151023045616.1666.65370@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "John Pullokkaran" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38211/ X-Sender: "John Pullokkaran" References: <20151023032129.1667.27900@reviews.apache.org> In-Reply-To: <20151023032129.1667.27900@reviews.apache.org> Reply-To: "John Pullokkaran" X-ReviewRequest-Repository: hive-git --===============7742597553157179951== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38211/#review103715 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 962) Pushing just limit without pushing orderby is not sufficent. Limit almost always will have preceeding order by. Order by pushdown also nneds to be handled. - John Pullokkaran On Oct. 23, 2015, 3:21 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38211/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 3:21 a.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-11684 > https://issues.apache.org/jira/browse/HIVE-11684 > > > Repository: hive-git > > > Description > ------- > > Implement limit pushdown through outer join in CBO > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 23ae0dcca405bfe5521b1638f5c7f4e720c1a493 > itests/src/test/resources/testconfiguration.properties fa1d89d2169023b3842829e762e02b896909b4b0 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSortLimit.java 82fdc0e04011aa585912ce5aae5e3245e5e5bb01 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectSortTransposeRule.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortRemoveRule.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java 6948fb16c6a3c9ce456a900536bee4c0d9b1614e > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java 715f24fc1872a54637a47bf80bb29e4a2e053779 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e13356ce16626bda1d9b6553ac5f191a65243394 > ql/src/test/queries/clientpositive/limit_join_transpose.q PRE-CREATION > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_3.q PRE-CREATION > ql/src/test/results/clientpositive/limit_join_transpose.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_3.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/38211/diff/ > > > Testing > ------- > > Two new tests added: limit_join_transpose.q and tez_dynpart_hashjoin_3.q (only Tez) > > > Thanks, > > Jesús Camacho Rodríguez > > --===============7742597553157179951==--