Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B52F818C95 for ; Tue, 13 Oct 2015 01:27:50 +0000 (UTC) Received: (qmail 88080 invoked by uid 500); 13 Oct 2015 01:27:50 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 87997 invoked by uid 500); 13 Oct 2015 01:27:50 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 87985 invoked by uid 99); 13 Oct 2015 01:27:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 01:27:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 912C2276EDB; Tue, 13 Oct 2015 01:27:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7628964511549224003==" MIME-Version: 1.0 Subject: Review Request 39253: SemanticAnalysis of "a=1" can result in a new Configuration() object From: "Navis Ryu" To: "Navis Ryu" , "hive" Date: Tue, 13 Oct 2015 01:27:48 -0000 Message-ID: <20151013012748.28635.56195@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Navis Ryu" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39253/ X-Sender: "Navis Ryu" Reply-To: "Navis Ryu" X-ReviewRequest-Repository: hive-git --===============7628964511549224003== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39253/ ----------------------------------------------------------- Review request for hive. Bugs: HIVE-11679 https://issues.apache.org/jira/browse/HIVE-11679 Repository: hive-git Description ------- {code} public static ExprNodeGenericFuncDesc newInstance(GenericUDF genericUDF, String funcText, List children) throws UDFArgumentException { ... if (genericUDF instanceof GenericUDFBaseCompare && children.size() == 2) { TypeInfo oiTypeInfo0 = children.get(0).getTypeInfo(); TypeInfo oiTypeInfo1 = children.get(1).getTypeInfo(); SessionState ss = SessionState.get(); Configuration conf = (ss != null) ? ss.getConf() : new Configuration(); {code} This is both a SessionState.get() which is a threadlocal lookup or worse, a new Configuration() which means XML parsing of multiple files for each equality expression in the query. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/JoinTypeCheckCtx.java dccd1d9 ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java fbe93f9 ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 61ee2bd ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2d7d9d4 ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java e0cd398 ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java f95ee8d ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 4af07ad ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckCtx.java 8ad28be ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java ab5d006 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeColumnListDesc.java be78e73 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDesc.java 328bd86 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java b5d2ddf ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/MatchPath.java cc2b77b ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionResolver.java 71034d7 Diff: https://reviews.apache.org/r/39253/diff/ Testing ------- Thanks, Navis Ryu --===============7628964511549224003==--