Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A9641876A for ; Thu, 1 Oct 2015 20:28:47 +0000 (UTC) Received: (qmail 93574 invoked by uid 500); 1 Oct 2015 20:28:12 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 93494 invoked by uid 500); 1 Oct 2015 20:28:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 93477 invoked by uid 99); 1 Oct 2015 20:28:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2015 20:28:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1E92C275D64; Thu, 1 Oct 2015 20:28:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7903344051174834726==" MIME-Version: 1.0 Subject: Re: Review Request 38783: HIVE-11969 start Tez session in background when starting CLI From: "Sergey Shelukhin" To: "Siddharth Seth" , "Gunther Hagleitner" Cc: "hive" , "Sergey Shelukhin" Date: Thu, 01 Oct 2015 20:28:12 -0000 Message-ID: <20151001202812.1726.159@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sergey Shelukhin" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38783/ X-Sender: "Sergey Shelukhin" References: <20150930222555.23563.6363@reviews.apache.org> In-Reply-To: <20150930222555.23563.6363@reviews.apache.org> Reply-To: "Sergey Shelukhin" X-ReviewRequest-Repository: hive-git --===============7903344051174834726== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 30, 2015, 10:25 p.m., Siddharth Seth wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java, line 154 > > > > > > Minor: Second parameter needed? Is always null Kept it for consistency with open(), to which it is passed in some places - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38783/#review101167 ----------------------------------------------------------- On Sept. 26, 2015, 1:36 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38783/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2015, 1:36 a.m.) > > > Review request for hive, Gunther Hagleitner and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > See JIRA > > > Diffs > ----- > > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d62fd5c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 568ebbe > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 014941e > > Diff: https://reviews.apache.org/r/38783/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > > --===============7903344051174834726==--