hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HIVE-12066) Add javadoc for methods added to public APIs
Date Thu, 08 Oct 2015 02:56:26 GMT
Owen O'Malley created HIVE-12066:
------------------------------------

             Summary: Add javadoc for methods added to public APIs
                 Key: HIVE-12066
                 URL: https://issues.apache.org/jira/browse/HIVE-12066
             Project: Hive
          Issue Type: Sub-task
            Reporter: Owen O'Malley
            Assignee: Sergey Shelukhin


Looking through the changes for ORC, there are methods being added without documentation:

{code}
--- ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java
+++ ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java
@@ -360,8 +353,18 @@ RecordReader rows(long offset, long length,

   MetadataReader metadata() throws IOException;

+  List<Integer> getVersionList();
+
+  int getMetadataSize();
+
+  List<OrcProto.StripeStatistics> getOrcProtoStripeStatistics();
+
+  List<StripeStatistics> getStripeStatistics();
+
+  List<OrcProto.ColumnStatistics> getOrcProtoFileStatistics();
+
+  DataReader createDefaultDataReader(boolean useZeroCopy);
+
{code}

You really need to look through all of the interfaces and fix them before merging into master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message