hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 37778: HIVE-11634
Date Fri, 30 Oct 2015 00:18:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37778/#review104502
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java (line 338)
<https://reviews.apache.org/r/37778/#comment162753>

    If all expr nodes are partition cols/constants and if they come from same table then we
should bail out.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java (line 470)
<https://reviews.apache.org/r/37778/#comment162754>

    The col names in struct should be unique.
    GetName would retutn class name and could result in data corruption as there could be
duplicate names in struct typeinfo.
    
    We should instead use ExprNodeGenericFuncDesc.newInsatnce which will take care of generating
appropriate struct col names..


- John Pullokkaran


On Oct. 29, 2015, 11:32 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37778/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 11:32 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support partition pruning for IN(STRUCT(partcol, nonpartcol..)...)
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 59b66cd 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 7ee5081 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java 4799b4d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java 7cdc730

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/OpProcFactory.java 7262164 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 6a31689 
>   ql/src/test/queries/clientpositive/pcs.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/pointlookup.q 1aef2ef 
>   ql/src/test/queries/clientpositive/pointlookup2.q 31bebbb 
>   ql/src/test/queries/clientpositive/pointlookup3.q 3daa94b 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization_acid.q.out eca29df 
>   ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out 4320f01 
>   ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out
e30465d 
>   ql/src/test/results/clientpositive/pcs.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/pointlookup.q.out 7e19be4 
>   ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 7e28c77 
>   ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 1103e80

> 
> Diff: https://reviews.apache.org/r/37778/diff/
> 
> 
> Testing
> -------
> 
> Local testing done. More unit tests coming in the next patch.
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message