hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 38211: HIVE-11684
Date Fri, 23 Oct 2015 04:56:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38211/#review103715
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 962)
<https://reviews.apache.org/r/38211/#comment161786>

    Pushing just limit without pushing orderby is not sufficent.
    
    Limit almost always will have preceeding order by.
    Order by pushdown also nneds to be handled.


- John Pullokkaran


On Oct. 23, 2015, 3:21 a.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38211/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 3:21 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-11684
>     https://issues.apache.org/jira/browse/HIVE-11684
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Implement limit pushdown through outer join in CBO
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 23ae0dcca405bfe5521b1638f5c7f4e720c1a493

>   itests/src/test/resources/testconfiguration.properties fa1d89d2169023b3842829e762e02b896909b4b0

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSortLimit.java
82fdc0e04011aa585912ce5aae5e3245e5e5bb01 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectSortTransposeRule.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortRemoveRule.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
6948fb16c6a3c9ce456a900536bee4c0d9b1614e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java
715f24fc1872a54637a47bf80bb29e4a2e053779 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e13356ce16626bda1d9b6553ac5f191a65243394

>   ql/src/test/queries/clientpositive/limit_join_transpose.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_3.q PRE-CREATION 
>   ql/src/test/results/clientpositive/limit_join_transpose.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_3.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38211/diff/
> 
> 
> Testing
> -------
> 
> Two new tests added: limit_join_transpose.q and tez_dynpart_hashjoin_3.q (only Tez)
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message