hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 29199: HIVE-9013: Hive set command exposes metastore db password
Date Fri, 23 Oct 2015 00:49:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29199/#review103701
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 78)
<https://reviews.apache.org/r/29199/#comment161769>

    would Set<String> be more suitable as we are mainly doing .contains() check at run
time ?


- Thejas Nair


On Oct. 23, 2015, 12:12 a.m., Binglin Chang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29199/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 12:12 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-9013: Hive set command exposes metastore db password
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6c7adbd 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 06a83ae 
> 
> Diff: https://reviews.apache.org/r/29199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Binglin Chang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message