hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pengcheng xiong" <pxi...@hortonworks.com>
Subject Re: Review Request 39374: HIVE-12164
Date Fri, 16 Oct 2015 18:54:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39374/#review102966
-----------------------------------------------------------


LGTM +1 (pending new around of QA). Only one minor issue, we may also remove all the configurations
for TempStatsStore as well. They appear in following places:
{code}
./common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:1352:        "jdbc:derby:;databaseName=TempStatsStore;create=true",
./data/conf/hive-site.xml:68:  <value>jdbc:derby:;databaseName=${test.tmp.dir}/TempStatsStore;create=true</value>
./data/conf/llap/hive-site.xml:78:  <value>jdbc:derby:;databaseName=${test.tmp.dir}/TempStatsStore;create=true</value>
./data/conf/spark/standalone/hive-site.xml:54:  <value>jdbc:derby:;databaseName=${test.tmp.dir}/TempStatsStore;create=true</value>
./data/conf/spark/yarn-client/hive-site.xml:54:  <value>jdbc:derby:;databaseName=${test.tmp.dir}/TempStatsStore;create=true</value>
./data/conf/tez/hive-site.xml:78:  <value>jdbc:derby:;databaseName=${test.tmp.dir}/TempStatsStore;create=true</value>
{code}
Thanks.

- pengcheng xiong


On Oct. 16, 2015, 3:28 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39374/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 3:28 a.m.)
> 
> 
> Review request for hive and pengcheng xiong.
> 
> 
> Bugs: HIVE-12164
>     https://issues.apache.org/jira/browse/HIVE-12164
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Remove jdbc stats collection mechanism
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java b16b231 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0fcd39b 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/stats/DummyStatsAggregator.java
eb3f6eb 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/stats/KeyVerifyingStatsAggregator.java
4e00316 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java b7c1267 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 9775645 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 83b4969 
>   ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanMapper.java 2a7e979

>   ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java b9863d9 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorSpark.java 4c01b25

>   ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java 662c106

>   ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsPublisher.java e5f1400 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsAggregator.java b115daf 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsCollectionTaskIndependent.java 52c06c2

>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java b9878a3 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java 6dfc178 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsPublisher.java aa2bf62 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java d8c9926 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java 0318a8c 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsSetupConstants.java e39fc5b

>   ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java 59d94d5 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestFileSinkOperator.java d22d022 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestStatsPublisherEnhanced.java c257797

>   ql/src/test/queries/clientpositive/alter_table_update_status.q 4cc1a18 
>   ql/src/test/queries/clientpositive/analyze_tbl_part.q 9040bd4 
>   ql/src/test/queries/clientpositive/lb_fs_stats.q 7f31797 
>   ql/src/test/queries/clientpositive/metadata_only_queries.q 70fac92 
>   ql/src/test/queries/clientpositive/metadata_only_queries_with_filters.q a6f1148 
>   ql/src/test/queries/clientpositive/stats19.q ccdad6b 
>   ql/src/test/queries/clientpositive/stats_only_null.q b2bd4dc 
>   ql/src/test/queries/clientpositive/statsfs.q 82a2295 
> 
> Diff: https://reviews.apache.org/r/39374/diff/
> 
> 
> Testing
> -------
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message