hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 38292: HIVE-11768 java.io.DeleteOnExitHook leaks memory on long running Hive Server2 Instances
Date Tue, 13 Oct 2015 21:35:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38292/#review102537
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 309)
<https://reviews.apache.org/r/38292/#comment160236>

    I think this method could be re-used in other parts of hive as well. How about adding
this a FileUtils.deleteTmpFile and a new FileUtils.createTmpFile method ?
    Can you also add a unit test for those methods ?



ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 871)
<https://reviews.apache.org/r/38292/#comment160237>

    same as above comment . A method in FileUtils for use throughout hive would be useful.


- Thejas Nair


On Oct. 13, 2015, 1:19 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38292/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 1:19 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> More than 490,000 paths was added to java.io.DeleteOnExitHook on one of our long running
HiveServer2 instances,taken up more than 100MB on heap.
>   Most of the paths contains a suffix of ".pipeout".
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hive/common/util/ShutdownHookManager.java fd2f20a 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 41b4bb1 
>   service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java 1d1e995

>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 175348b 
> 
> Diff: https://reviews.apache.org/r/38292/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message