hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 39199: HIVE-12084 : Hive queries with ORDER BY and large LIMIT fails with OutOfMemoryError Java heap space
Date Tue, 13 Oct 2015 20:30:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39199/#review102527
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/VerifyTopNMemoryUsage.java (line
51)
<https://reviews.apache.org/r/39199/#comment160219>

    1. Memory requirements for hashreducer should be in TopNHash & overridden by subclasses
if needed.
    2. We should use avgtuple size & remove dependency on key size
    3. In runtime checks in TopNHash use memory required from #1


- John Pullokkaran


On Oct. 13, 2015, 7:37 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39199/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 7:37 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Please look at https://issues.apache.org/jira/browse/HIVE-12084
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java 49706b1

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/VerifyTopNMemoryUsage.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java a60527b 
>   ql/src/test/queries/clientpositive/topn.q PRE-CREATION 
>   ql/src/test/results/clientpositive/topn.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message