hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Review Request 39036: HIVE-12038 : Fix the 'overall' section in the HiveQA report
Date Tue, 06 Oct 2015 02:12:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39036/
-----------------------------------------------------------

Review request for hive, Brock Noland and Sergio Pena.


Bugs: HIVE-12038
    https://issues.apache.org/jira/browse/HIVE-12038


Repository: hive-git


Description
-------

Remove the overall section, fix the comment format, and add unit tests to test this piece
of code.


Diffs
-----

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java 37127ea

  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java 2ce1dc9

  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.testErrorWithMessages.approved.txt
PRE-CREATION 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.testErrorWithoutMessages.approved.txt
PRE-CREATION 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.testFailAdd.approved.txt
PRE-CREATION 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.testFailNoAdd.approved.txt
PRE-CREATION 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.testSuccessAdd.approved.txt
PRE-CREATION 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.testSuccessNoAdd.approved.txt
PRE-CREATION 
  testutils/ptest2/src/test/resources/test-configuration.properties caba9ea 

Diff: https://reviews.apache.org/r/39036/diff/


Testing
-------

Add unit tests.


Thanks,

Szehon Ho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message