hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 38783: HIVE-11969 start Tez session in background when starting CLI
Date Thu, 01 Oct 2015 20:28:12 GMT


> On Sept. 30, 2015, 10:25 p.m., Siddharth Seth wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java, line 154
> > <https://reviews.apache.org/r/38783/diff/1/?file=1085096#file1085096line154>
> >
> >     Minor: Second parameter needed? Is always null

Kept it for consistency with open(), to which it is passed in some places


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38783/#review101167
-----------------------------------------------------------


On Sept. 26, 2015, 1:36 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38783/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 1:36 a.m.)
> 
> 
> Review request for hive, Gunther Hagleitner and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d62fd5c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 568ebbe 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 014941e 
> 
> Diff: https://reviews.apache.org/r/38783/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message