Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B2E8818CE1 for ; Wed, 30 Sep 2015 23:12:44 +0000 (UTC) Received: (qmail 96573 invoked by uid 500); 30 Sep 2015 23:12:44 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 96497 invoked by uid 500); 30 Sep 2015 23:12:44 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 96479 invoked by uid 99); 30 Sep 2015 23:12:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2015 23:12:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0C8792753E4; Wed, 30 Sep 2015 23:12:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6956982647350429969==" MIME-Version: 1.0 Subject: Re: Review Request 38894: HIVE-11995: Remove repetitively setting permissions in insert/load overwrite partition From: "Szehon Ho" To: "Szehon Ho" , "Sergio Pena" Cc: "hive" , "Chaoyu Tang" Date: Wed, 30 Sep 2015 23:12:41 -0000 Message-ID: <20150930231241.23563.17667@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Szehon Ho" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38894/ X-Sender: "Szehon Ho" References: <20150930215858.23614.62115@reviews.apache.org> In-Reply-To: <20150930215858.23614.62115@reviews.apache.org> Reply-To: "Szehon Ho" X-ReviewRequest-Repository: hive-git --===============6956982647350429969== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38894/#review101178 ----------------------------------------------------------- Ship it! Nice, this is a ton cleaner to use the util method! Thanks! - Szehon Ho On Sept. 30, 2015, 9:58 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38894/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2015, 9:58 p.m.) > > > Review request for hive, Sergio Pena and Szehon Ho. > > > Bugs: HIVE-11995 > https://issues.apache.org/jira/browse/HIVE-11995 > > > Repository: hive-git > > > Description > ------- > > Table and partition permissions are repetitively set in Hive.ReplaceFiles by inheritFromTable which sometimes is not necessary and causing performance issue. For example, in dyanamically insert/load overwrite multiple level of partitions (e.g. table/p1/p2/p3/p4), the p1,p2 p3 permissions are set repetitively. > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java d98082f > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 10cafb6 > > Diff: https://reviews.apache.org/r/38894/diff/ > > > Testing > ------- > > TestExtendedAcls and TestFolderPermissions have existing test cases which passed in my local machine. > Submitted for precommit build > > > Thanks, > > Chaoyu Tang > > --===============6956982647350429969==--