Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B62517508 for ; Fri, 25 Sep 2015 01:49:43 +0000 (UTC) Received: (qmail 46619 invoked by uid 500); 25 Sep 2015 01:49:42 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 46532 invoked by uid 500); 25 Sep 2015 01:49:42 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 46516 invoked by uid 99); 25 Sep 2015 01:49:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Sep 2015 01:49:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4040F286B4C; Fri, 25 Sep 2015 01:49:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8288503121090353266==" MIME-Version: 1.0 Subject: Re: Review Request 38493: HIVE-11132 From: "Gopal V" To: "Gopal V" Cc: "Ashutosh Chauhan" , "hive" Date: Fri, 25 Sep 2015 01:49:40 -0000 Message-ID: <20150925014940.24659.94991@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Gopal V" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38493/ X-Sender: "Gopal V" References: <20150925013728.24659.89338@reviews.apache.org> In-Reply-To: <20150925013728.24659.89338@reviews.apache.org> Reply-To: "Gopal V" X-ReviewRequest-Repository: hive-git --===============8288503121090353266== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38493/#review100513 ----------------------------------------------------------- Ship it! Ship It! - Gopal V On Sept. 25, 2015, 1:37 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38493/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 1:37 a.m.) > > > Review request for hive and Gopal V. > > > Bugs: HIVE-11132 > https://issues.apache.org/jira/browse/HIVE-11132 > > > Repository: hive-git > > > Description > ------- > > Queries using join and group by produce incorrect output when hive.auto.convert.join=false and hive.optimize.reducededuplication=true > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java 56334ed > ql/src/test/queries/clientpositive/join_grp_diff_keys.q PRE-CREATION > ql/src/test/results/clientpositive/join_grp_diff_keys.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/38493/diff/ > > > Testing > ------- > > New q test and regression suite. > > > Thanks, > > Ashutosh Chauhan > > --===============8288503121090353266==--