Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76B0910C02 for ; Wed, 2 Sep 2015 11:14:31 +0000 (UTC) Received: (qmail 24539 invoked by uid 500); 2 Sep 2015 11:14:31 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 24445 invoked by uid 500); 2 Sep 2015 11:14:31 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 24429 invoked by uid 99); 2 Sep 2015 11:14:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Sep 2015 11:14:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 425DE26DEC4; Wed, 2 Sep 2015 11:14:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7775803384414837182==" MIME-Version: 1.0 Subject: Re: Review Request 37925: HIVE-11487: Add getNumPartitionsByFilter api in metastore api From: "Akshay Goyal" To: "Amareshwari Sriramadasu" Cc: "hive" , "Akshay Goyal" Date: Wed, 02 Sep 2015 11:14:29 -0000 Message-ID: <20150902111429.16295.88599@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Akshay Goyal" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37925/ X-Sender: "Akshay Goyal" References: <20150830204140.16295.29462@reviews.apache.org> In-Reply-To: <20150830204140.16295.29462@reviews.apache.org> Reply-To: "Akshay Goyal" X-ReviewRequest-Repository: hive-git --===============7775803384414837182== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37925/ ----------------------------------------------------------- (Updated Sept. 2, 2015, 11:14 a.m.) Review request for hive and Amareshwari Sriramadasu. Changes ------- removed auto generated code Bugs: HIVE-11487 https://issues.apache.org/jira/browse/HIVE-11487 Repository: hive-git Description ------- Adding api for getting number of partitions for a filter. In order to be more optimal when only interested in the number. getAllPartitions will construct all the partition object which can be time consuming and not required. Diffs (updated) ----- metastore/if/hive_metastore.thrift d651195e0477ee607657fec13b68ff3184ddbebf metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1840e76cc567e95e1942d912b8ab0db516d63a3b metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 482f27851c0732604cdb04e9a0b981757643210b metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 5fde6d34bff7fd091b3ca36472d929269660c9b9 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 522fcc275f42a3b75af9f4bee9bf1ab3cd70364b metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java d165fc82386eafa5200068f5c56a9e98788627aa metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 7c85eea21375f349f88e918329030364acca2771 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f184c568b5eb5b16f239c6128f1ad20bd83957cb metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 83fb4bb900a51101d8c411d199357c8ddd29486e ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 396c07044ec69d8b74e38fb156333b6eb35b9f4d Diff: https://reviews.apache.org/r/37925/diff/ Testing ------- Thanks, Akshay Goyal --===============7775803384414837182==--