hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thejas Nair <thejas.n...@gmail.com>
Subject Re: unit tests in patches
Date Mon, 21 Sep 2015 21:33:21 GMT
+1

On a slightly different note, it would also be great if we can plug in
patch testing that checks for lack of test changes and other issues
like hadoop has . For example, see -
https://issues.apache.org/jira/browse/HDFS-9091?focusedCommentId=14791395&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14791395


On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan <hashutosh@apache.org> wrote:
> Hi everyone,
>
> Generally, its a good idea to add unit tests in patches especially when its
> easy to repro (e.g,., NPE). This may not always be possible, but we should
> aim to add tests wherever we can. In addition to regression testing, tests
> also proves the existence of bug. I would especially like to call out the
> attention of committers that they make sure patches they are committing has
> a test case. In case its not possible to repro test, there should be an
> explanation on jira.
>
> Related to this is affect versions and fix versions. Reporter should update
> this field while creating jiras. There is some confusion around exactly
> what a fix version is. Fix version indicates earliest version on which this
> fix is available. So, it should be updated after patch is committed to
> reflect which upcoming version it will be available on. Please don't use it
> as 'target version' that is a version on which you would like to see it
> fixed.
>
> Examples of commits where I didn't follow what I am preaching :) but plan
> to improve on:
>
> https://issues.apache.org/jira/browse/HIVE-9377
>
> https://issues.apache.org/jira/browse/HIVE-9507
>
> https://issues.apache.org/jira/browse/HIVE-11285
>
> https://issues.apache.org/jira/browse/HIVE-9386
>
> https://issues.apache.org/jira/browse/HIVE-10808

Mime
View raw message