hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang" <ctang...@gmail.com>
Subject Re: Review Request 38894: HIVE-11995: Remove repetitively setting permissions in insert/load overwrite partition
Date Wed, 30 Sep 2015 21:58:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38894/
-----------------------------------------------------------

(Updated Sept. 30, 2015, 9:58 p.m.)


Review request for hive, Sergio Pena and Szehon Ho.


Changes
-------

Upload a new patch with fixes to tests. I think for overwrite an existing table/partitions,
Hive should inherit the existing table/partition permission, and only overwrite their contents.

Modify the tests accordingly to set the tests correctly.


Bugs: HIVE-11995
    https://issues.apache.org/jira/browse/HIVE-11995


Repository: hive-git


Description
-------

Table and partition permissions are repetitively set in Hive.ReplaceFiles by inheritFromTable
which sometimes is not necessary and causing performance issue. For example, in dyanamically
insert/load overwrite multiple level of partitions (e.g. table/p1/p2/p3/p4), the p1,p2 p3
permissions are set repetitively.


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java
d98082f 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 10cafb6 

Diff: https://reviews.apache.org/r/38894/diff/


Testing
-------

TestExtendedAcls and TestFolderPermissions have existing test cases which passed in my local
machine.
Submitted for precommit build


Thanks,

Chaoyu Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message