hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths
Date Wed, 30 Sep 2015 01:01:23 GMT


> On Sept. 30, 2015, 12:27 a.m., Gopal V wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 5751
> > <https://reviews.apache.org/r/38702/diff/1/?file=1083680#file1083680line5751>
> >
> >     Wrap this with a ByteBuffer impl of your own instead of doing Reflection.

Default implementation uses fields in many places and not methods, so these would need to
be c/p-ed (array()/hasArray() is the one that fails in thrift). Ctors are not visible. etc.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38702/#review101051
-----------------------------------------------------------


On Sept. 24, 2015, 1:03 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38702/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 1:03 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f3e2168 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 815f499 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 6f15fd0

>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java e4a6cdb 
>   ql/pom.xml 36b3433 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 3511e73 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java 87881b6 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2500fb6 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java cc03df7 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java ab539c4 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 99896c6 
> 
> Diff: https://reviews.apache.org/r/38702/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message