hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 38659: HIVE-11926: Stats annotation might not extract stats for varchar/decimal columns
Date Wed, 23 Sep 2015 17:59:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38659/#review100247
-----------------------------------------------------------

Ship it!


Ship It!

- Xuefu Zhang


On Sept. 23, 2015, 4:04 a.m., Chaoyu Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38659/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 4:04 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang.
> 
> 
> Bugs: HIVE-11926
>     https://issues.apache.org/jira/browse/HIVE-11926
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> As Hive-11926 describes, Stats annotation might not be able to extract stats from columns
with uppercase type names (VARCHAR/DECIMAL) since StatsUtils uses startWith to compare them
with lowercase SerdeConstants type name.
> This patch converts the type names to lowercase before they are compared with SerdeConstants.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 2c970bd 
> 
> Diff: https://reviews.apache.org/r/38659/diff/
> 
> 
> Testing
> -------
> 
> Pre-commit build and manual tests.
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message