hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 37778: HIVE-11634
Date Thu, 17 Sep 2015 18:05:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37778/#review99389
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java (line 176)
<https://reviews.apache.org/r/37778/#comment156289>

    I think we do not need this recurvise call; that's the work of the walker.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java (line 276)
<https://reviews.apache.org/r/37778/#comment156291>

    Could we add an exit condition if all aliases were partition aliases and belong to the
same table i.e. we will end up with the same predicate?
    
    This might be useful if we still keep the logic in HIVE-11726.



ql/src/test/queries/clientpositive/pointlookup.q (line 21)
<https://reviews.apache.org/r/37778/#comment156267>

    


- Jesús Camacho Rodríguez


On Sept. 10, 2015, 6:40 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37778/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 6:40 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support partition pruning for IN(STRUCT(partcol, nonpartcol..)...)
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d2c5885 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 439f616 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java d83636d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/OpProcFactory.java 7262164 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 6a31689 
>   ql/src/test/queries/clientpositive/pcs.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/pointlookup.q 1aef2ef 
>   ql/src/test/queries/clientpositive/pointlookup2.q 31bebbb 
>   ql/src/test/queries/clientpositive/pointlookup3.q 3daa94b 
>   ql/src/test/results/clientpositive/pcs.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/pointlookup.q.out 7e19be4 
>   ql/src/test/results/clientpositive/pointlookup2.q.out 55edd90 
>   ql/src/test/results/clientpositive/pointlookup3.q.out 4cfb97e 
> 
> Diff: https://reviews.apache.org/r/37778/diff/
> 
> 
> Testing
> -------
> 
> Local testing done. More unit tests coming in the next patch.
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message