hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 38247: HIVE-11778 Merge beeline-cli branch to trunk
Date Fri, 11 Sep 2015 22:46:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38247/#review98694
-----------------------------------------------------------



beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 96)
<https://reviews.apache.org/r/38247/#comment155237>

    Could we remove this static import, as it's not common in Hive and it's referred only
once in the code?



beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 1085)
<https://reviews.apache.org/r/38247/#comment155245>

    Again I have trouble understanding this: if cmdMap.size() > 1, then there must be at
lease one match, right? Then, how cmdMap.get(line) can return null, as suggested in line 1088?
Further, how can handle == null suggest multiple matches? I know this is old code, but let's
clean it up if necessary.



beeline/src/java/org/apache/hive/beeline/Commands.java (line 815)
<https://reviews.apache.org/r/38247/#comment155259>

    This seems weird as the method isn't new but shown as new here.



ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 393)
<https://reviews.apache.org/r/38247/#comment155247>

    Nit: remove leading space/tab.


- Xuefu Zhang


On Sept. 10, 2015, 3:35 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38247/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 3:35 a.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The changes we made in beeline-cli branch
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 3cd2a8b 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 3388391 
>   beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java PRE-CREATION

>   beeline/src/java/org/apache/hive/beeline/ClientHook.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 3cdcfb8 
>   beeline/src/java/org/apache/hive/beeline/cli/CliOptionsProcessor.java PRE-CREATION

>   beeline/src/java/org/apache/hive/beeline/cli/HiveCli.java PRE-CREATION 
>   beeline/src/test/org/apache/hive/beeline/TestClientCommandHookFactory.java PRE-CREATION

>   beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java PRE-CREATION 
>   beeline/src/test/resources/hive-site.xml PRE-CREATION 
>   bin/ext/cli.sh 914aae3 
>   bin/ext/util/execHiveCmd.sh 167cc40 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d62fd5c 
>   common/src/java/org/apache/hadoop/hive/conf/HiveVariableSource.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/VariableSubstitution.java PRE-CREATION

>   common/src/test/org/apache/hadoop/hive/conf/TestVariableSubstitution.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8

>   ql/src/java/org/apache/hadoop/hive/ql/parse/VariableSubstitution.java e8b1d96 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java 0558c53

>   ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java 25ce168 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java 9052c82

>   ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java cc0414d 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 2414e12 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 7ed8e5f 
>   service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java bcc66cf

>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java cc9df76 
> 
> Diff: https://reviews.apache.org/r/38247/diff/
> 
> 
> Testing
> -------
> 
> UT and smoke test passed locally
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message