hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cheng xu" <cheng.a...@intel.com>
Subject Re: Review Request 38044: HIVE-11640 Shell command doesn't work for new CLI[Beeline-cli branch]
Date Sun, 06 Sep 2015 01:45:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38044/#review97878
-----------------------------------------------------------



beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 1091)
<https://reviews.apache.org/r/38044/#comment153947>

    That's possible. You can deep into the code of AbstractCommandHandler. The condition of
match is whether the names is starting with the first part of the line. It means the command
"!l;" is valid since there's only one match "list" exists.


- cheng xu


On Sept. 2, 2015, 3:16 p.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38044/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 3:16 p.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-11640
>     https://issues.apache.org/jira/browse/HIVE-11640
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Fixed issues includes:
> * Support the case that one line contains multi-commands with ";" seperated
> * Fix the nullempty string for new cli mode
> * Resolve command doesn't support issue when executing files
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 1e4759b 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 5e5cfec 
>   beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java e06d2ea 
> 
> Diff: https://reviews.apache.org/r/38044/diff/
> 
> 
> Testing
> -------
> 
> Local smoke test passed and unit test passed locally
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message