Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 391871825E for ; Tue, 18 Aug 2015 20:17:19 +0000 (UTC) Received: (qmail 25542 invoked by uid 500); 18 Aug 2015 20:17:18 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 25469 invoked by uid 500); 18 Aug 2015 20:17:18 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 25377 invoked by uid 99); 18 Aug 2015 20:17:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Aug 2015 20:17:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 71EB4D5331; Tue, 18 Aug 2015 20:17:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0537250254099417461==" MIME-Version: 1.0 Subject: Re: Review Request 37563: HIVE-10697 Fix for ObjectInspectorConvertors#UnionConvertor doing a faulty conversion From: "Swarnim Kulkarni" To: "Hari Sankar Sivarama Subramaniyan" Cc: "Swarnim Kulkarni" , "hive" Date: Tue, 18 Aug 2015 20:17:17 -0000 Message-ID: <20150818201717.1535.80566@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Swarnim Kulkarni" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37563/ X-Sender: "Swarnim Kulkarni" References: <20150818180615.1535.79620@reviews.apache.org> In-Reply-To: <20150818180615.1535.79620@reviews.apache.org> Reply-To: "Swarnim Kulkarni" X-ReviewRequest-Repository: hive-git --===============0537250254099417461== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 18, 2015, 6:06 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java, line 467 > > > > > > Can you make sure that (Byte)inputFieldTag).intValue() is >= 0 && < fieldConverters.size(). If not, you can either throw an exception or NULL based on how you handle extra tags. Ah..good call. I think we only need to care about extra fields in the input as that is what we are parsing the tags from. I'll get this updated. - Swarnim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37563/#review95749 ----------------------------------------------------------- On Aug. 18, 2015, 3:35 a.m., Swarnim Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37563/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 3:35 a.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > ------- > > HIVE-10697 Fix for ObjectInspectorConvertors#UnionConvertor doing a faulty conversion > > > Diffs > ----- > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java 8ef8ce1736d50f0f9163cd5e3fd00ddd4bd810da > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SettableUnionObjectInspector.java a64aee074d05a14c3c72079ff960039811936419 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java d1b11e82730e57f6894145478aae7c0c0c26e518 > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java 11852833577149152cefaef50ee49328733c9dde > > Diff: https://reviews.apache.org/r/37563/diff/ > > > Testing > ------- > > Unit tests added. > > > Thanks, > > Swarnim Kulkarni > > --===============0537250254099417461==--