Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 47B8118DFC for ; Fri, 7 Aug 2015 03:38:06 +0000 (UTC) Received: (qmail 50256 invoked by uid 500); 7 Aug 2015 03:38:05 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 50176 invoked by uid 500); 7 Aug 2015 03:38:05 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 50151 invoked by uid 99); 7 Aug 2015 03:38:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Aug 2015 03:38:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 84F56DA53C; Fri, 7 Aug 2015 03:38:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5638366218351952176==" MIME-Version: 1.0 Subject: Re: Review Request 37150: HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x <> 0) From: "Chao Sun" To: "Aihua Xu" , "hive" , "Chao Sun" Date: Fri, 07 Aug 2015 03:38:03 -0000 Message-ID: <20150807033803.11538.82260@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Chao Sun" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37150/ X-Sender: "Chao Sun" References: <20150806000116.11504.58654@reviews.apache.org> In-Reply-To: <20150806000116.11504.58654@reviews.apache.org> Reply-To: "Chao Sun" X-ReviewRequest-Repository: hive-git --===============5638366218351952176== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37150/#review94484 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java (line 532) why only this case cannot be folded? seems like the other cases, like "not (key < 3 and key is not null" would also have the same issue. ql/src/test/queries/clientpositive/folder_predicate.q (line 7) maybe add tests negation as well? e.g.: SELECT * FROM predicate_fold_tb WHERE NOT (value IS NOT NULL AND value >= 3); - Chao Sun On Aug. 6, 2015, 12:01 a.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37150/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 12:01 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x <> 0) > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java 410735c27e5372a0818e18e1a6dc5b07d7b986c0 > ql/src/test/queries/clientpositive/folder_predicate.q PRE-CREATION > ql/src/test/results/clientpositive/folder_predicate.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/37150/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > > --===============5638366218351952176==--