hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 37620: Hive Parser to Support multi col in clause (x, y..) in ((..), ..., ())
Date Mon, 31 Aug 2015 18:48:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37620/#review97121
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 434)
<https://reviews.apache.org/r/37620/#comment152885>

    Nit pick


- John Pullokkaran


On Aug. 21, 2015, 10:07 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37620/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 10:07 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Current hive only support single column in clause, e.g., 
> {code}select * from src where  col0 in (v1,v2,v3);{code}
> We want it to support 
> {code}select * from src where (col0,col1+3) in ((col0+v1,v2),(v3,v4-col1));{code}
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 64af7d1 
>   ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java
61b5892 
>   ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsPositive.java
4c84e91 
>   ql/src/test/queries/clientpositive/char_udf1.q 8848609 
>   ql/src/test/queries/clientpositive/multi_column_in.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/varchar_udf1.q 395fb12 
>   ql/src/test/results/clientpositive/char_udf1.q.java1.7.out ced0132 
>   ql/src/test/results/clientpositive/multi_column_in.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/varchar_udf1.q.java1.7.out 96ba06e 
> 
> Diff: https://reviews.apache.org/r/37620/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message