hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akshay Goyal" <akshaygoyal2...@gmail.com>
Subject Re: Review Request 33890: HIVE-10435: Make HiveSession implementation pluggable through configuration
Date Tue, 11 Aug 2015 07:18:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33890/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 7:18 a.m.)


Review request for hive and Amareshwari Sriramadasu.


Changes
-------

changes done as per review and test case fix.


Bugs: HIVE-10435
    https://issues.apache.org/jira/browse/HIVE-10435


Repository: hive-git


Description
-------

SessionManager in CLIService creates and keeps track of HiveSession. 
Right now, it creates HiveSessionImpl which is one implementation of HiveSession. This improvement
request is to make it pluggable through a configuration so that other implementations can
be passed.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fe4eb9f 
  service/src/java/org/apache/hive/service/cli/session/SessionManager.java c46bbce 
  service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java PRE-CREATION


Diff: https://reviews.apache.org/r/33890/diff/


Testing
-------

Newly added unit test passed.


Thanks,

Akshay Goyal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message