hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aihua Xu" <...@cloudera.com>
Subject Re: Review Request 37150: HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x <> 0)
Date Fri, 07 Aug 2015 17:53:56 GMT


> On Aug. 7, 2015, 3:38 a.m., Chao Sun wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java,
line 533
> > <https://reviews.apache.org/r/37150/diff/1/?file=1032991#file1032991line533>
> >
> >     why only this case cannot be folded? seems like the other cases, like "not (key
< 3 and key is not null" would also have the same issue.

Thanks for catching it.


- Aihua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37150/#review94484
-----------------------------------------------------------


On Aug. 6, 2015, 12:01 a.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37150/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 12:01 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x <>
0)
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java 410735c27e5372a0818e18e1a6dc5b07d7b986c0

>   ql/src/test/queries/clientpositive/folder_predicate.q PRE-CREATION 
>   ql/src/test/results/clientpositive/folder_predicate.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message