hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pengcheng xiong" <pxi...@hortonworks.com>
Subject Re: Review Request 36962: CBO: Calcite Operator To Hive Operator (Calcite Return Path): Groupby Optimizer assumes the schema can match after removing RS and GBY
Date Thu, 06 Aug 2015 17:17:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36962/#review94421
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 
<https://reviews.apache.org/r/36962/#comment149012>

    Sorry but I actually have a different opinion: (1) Hive is now complicated enough; putting
some unused code here is just adding complexity and compilation overhead. (2) If the dev would
like to use this kind of method in the future, he/she can implement it again. (3) This method
is very specific, e.g., it will not do anything if there are more than 1 child at any level.
It is not that generic.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupByOptimizer.java (line 573)
<https://reviews.apache.org/r/36962/#comment149011>

    True.


- pengcheng xiong


On Aug. 3, 2015, 11:30 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36962/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 11:30 p.m.)
> 
> 
> Review request for hive and Jesús Camacho Rodríguez.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> solution is to add a SEL in between
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 0f02737 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupByOptimizer.java af54286 
> 
> Diff: https://reviews.apache.org/r/36962/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message