Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6917618578 for ; Thu, 16 Jul 2015 00:45:27 +0000 (UTC) Received: (qmail 39655 invoked by uid 500); 16 Jul 2015 00:45:27 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 39587 invoked by uid 500); 16 Jul 2015 00:45:27 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 39571 invoked by uid 99); 16 Jul 2015 00:45:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jul 2015 00:45:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 957E0BCA48; Thu, 16 Jul 2015 00:45:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3891980803754259169==" MIME-Version: 1.0 Subject: Re: Review Request 36486: HIVE-11262 Skip MapJoin processing if the join hash table is empty From: "Jason Dere" To: "Matt McCline" , "Vikram Dixit Kumaraswamy" , "Wei Zheng" Cc: "Jason Dere" , "hive" Date: Thu, 16 Jul 2015 00:45:25 -0000 Message-ID: <20150716004525.17362.85433@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jason Dere" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36486/ X-Sender: "Jason Dere" References: <20150714220942.17362.30443@reviews.apache.org> In-Reply-To: <20150714220942.17362.30443@reviews.apache.org> Reply-To: "Jason Dere" X-ReviewRequest-Repository: hive-git --===============3891980803754259169== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36486/ ----------------------------------------------------------- (Updated July 16, 2015, 12:45 a.m.) Review request for hive, Matt McCline, Vikram Dixit Kumaraswamy, and Wei Zheng. Changes ------- Updating patch regarding size of HybridHashTableContainer, based on feedback from Wei Zheng - the on-disk hash partition size is based on both the on-disk hash table as well as the side table. Added a new field to keep track of the on-disk hash table size. Also made a couple of small fixes to HybridHashTableContainer: In MapJoin.reloadHashTable(), totalInMemRowCount was double counting the size of the side table, since the restoreHashMap had already added the side table values. hashMapOnDisk was not being reset to false when the on-disk hash table was being cleaned up. Bugs: HIVE-11262 https://issues.apache.org/jira/browse/HIVE-11262 Repository: hive-git Description ------- - Added size() method to HashTableContainer interface/implementations. - After loading hashTable, check if size == 0 and if join is all inner joins. If so, set done on the MapJoinOperator. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 15cafdd ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java e338a31 ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java 83a1521 ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainer.java 9d8cbcb ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTable.java fbe6b4c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastTableContainer.java 4b1d6f6 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/hashtable/VectorMapJoinHashTable.java 7e219ec ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedHashTable.java a2d4e4c Diff: https://reviews.apache.org/r/36486/diff/ Testing ------- Thanks, Jason Dere --===============3891980803754259169==--