Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CA09918730 for ; Thu, 9 Jul 2015 18:19:28 +0000 (UTC) Received: (qmail 80824 invoked by uid 500); 9 Jul 2015 18:19:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 80754 invoked by uid 500); 9 Jul 2015 18:19:28 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 80735 invoked by uid 99); 9 Jul 2015 18:19:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 18:19:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 78087BB060; Thu, 9 Jul 2015 18:19:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1417541928981758072==" MIME-Version: 1.0 Subject: Re: Review Request 36284: HIVE-11197 From: "Ashutosh Chauhan" To: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= Cc: "Ashutosh Chauhan" , "hive" Date: Thu, 09 Jul 2015 18:19:27 -0000 Message-ID: <20150709181927.1572.79301@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36284/ X-Sender: "Ashutosh Chauhan" References: <20150707230902.1572.18689@reviews.apache.org> In-Reply-To: <20150707230902.1572.18689@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive-git --===============1417541928981758072== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36284/ ----------------------------------------------------------- (Updated July 9, 2015, 6:19 p.m.) Review request for hive and Jesús Camacho Rodríguez. Changes ------- Updated with latest changes. Bugs: HIVE-11197 https://issues.apache.org/jira/browse/HIVE-11197 Repository: hive-git Description ------- While extracting join conditions follow Hive rules for type conversion instead of Calcite Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 024097e ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java 9ebb24f ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java fb67309 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java 668960e ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java 911ceda ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java c5ab055 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java a4484ec ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java c5e0e11 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java 960ec40 Diff: https://reviews.apache.org/r/36284/diff/ Testing ------- Existing tests. Thanks, Ashutosh Chauhan --===============1417541928981758072==--