Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 683771879E for ; Thu, 2 Jul 2015 01:10:08 +0000 (UTC) Received: (qmail 23248 invoked by uid 500); 2 Jul 2015 01:10:08 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 23176 invoked by uid 500); 2 Jul 2015 01:10:08 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 23162 invoked by uid 99); 2 Jul 2015 01:10:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jul 2015 01:10:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5E3AB1E00; Thu, 2 Jul 2015 01:10:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6845970995714948630==" MIME-Version: 1.0 Subject: Re: Review Request 36069: HIVE-11141 : Improve RuleRegExp when the Expression node stack gets huge From: "Hari Sankar Sivarama Subramaniyan" To: "John Pullokkaran" , "Mostafa Mokhtar" Cc: "Hari Sankar Sivarama Subramaniyan" , "hive" Date: Thu, 02 Jul 2015 01:10:06 -0000 Message-ID: <20150702011006.13308.25651@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Hari Sankar Sivarama Subramaniyan" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36069/ X-Sender: "Hari Sankar Sivarama Subramaniyan" References: <20150630225639.13308.92741@reviews.apache.org> In-Reply-To: <20150630225639.13308.92741@reviews.apache.org> Reply-To: "Hari Sankar Sivarama Subramaniyan" X-ReviewRequest-Repository: hive-git --===============6845970995714948630== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36069/ ----------------------------------------------------------- (Updated July 2, 2015, 1:10 a.m.) Review request for hive, John Pullokkaran and Mostafa Mokhtar. Changes ------- Thanks John for the review. Addressed John's comments. Repository: hive-git Description ------- Improve RuleRegExp when the Expression node stack gets huge Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java ddc96c2 ql/src/test/org/apache/hadoop/hive/ql/lib/TestRuleRegExp.java PRE-CREATION Diff: https://reviews.apache.org/r/36069/diff/ Testing ------- Local testing. Thanks, Hari Sankar Sivarama Subramaniyan --===============6845970995714948630==--