hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 36897: HIVE-11257
Date Wed, 29 Jul 2015 18:43:33 GMT


> On July 29, 2015, 6:07 p.m., pengcheng xiong wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java,
line 295
> > <https://reviews.apache.org/r/36897/diff/2/?file=1024453#file1024453line295>
> >
> >     please apply the Hive code format template for spaces.
> 
> Jesús Camacho Rodríguez wrote:
>     I will upload a new patch fixing it.

There is no style problem here, right?


- Jesús


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36897/#review93486
-----------------------------------------------------------


On July 29, 2015, 11:58 a.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36897/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 11:58 a.m.)
> 
> 
> Review request for hive and pengcheng xiong.
> 
> 
> Bugs: HIVE-11257
>     https://issues.apache.org/jira/browse/HIVE-11257
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> CBO: Calcite Operator To Hive Operator (Calcite Return Path): Method isCombinablePredicate
in HiveJoinToMultiJoinRule should be extended to support MultiJoin operators merge
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java
d0a29a76652c8af120a6efb252c75282730ef097 
> 
> Diff: https://reviews.apache.org/r/36897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message