hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF
Date Wed, 29 Jul 2015 07:34:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35902/#review93405
-----------------------------------------------------------



ql/src/test/results/clientpositive/vector_bround.q.out (line 62)
<https://reviews.apache.org/r/35902/#comment147780>

    This isn't showing "Execution mode: vectorized" which you should see in the explain plan
for the other vectorized tests


- Jason Dere


On July 27, 2015, 6:12 a.m., Alexander Pivovarov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35902/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 6:12 a.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Bugs: HIVE-11103
>     https://issues.apache.org/jira/browse/HIVE-11103
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-11103 Add banker's rounding BROUND UDF
> 
> 
> Diffs
> -----
> 
>   ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 6485a2ac5f12dbdba7bdf4d17ba18ad054c6f73b

>   common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java a8215f29aed3a0399ec274cc311a3c92e0cca55b

>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fabc21e2092561cbf98c35a406e4ee40e71fe1de

>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BRoundWithNumDigitsDoubleToDouble.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java ef800596deed612b525ed3371b196f275ad88e09

>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncBRoundWithNumDigitsDecimalToDecimal.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java
9f3e8a3fcacb17990c6644a67cf587ae9948adad 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java aef923e2c362a8d15b8dcc3467aef01a862c205c

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBRound.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 963e4a87c417798f95bb1490a4275339a61e869c

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java 0b389a5783fa2cf6643919c411ee57a7ed873d84

>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFBRound.java PRE-CREATION

>   ql/src/test/queries/clientpositive/udf_bround.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/vector_bround.q PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3

>   ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/vector_bround.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Pivovarov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message