hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 36475: HIVE-11082 Support multi edge between nodes in SparkPlan[Spark Branch]
Date Wed, 15 Jul 2015 13:18:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36475/#review91736
-----------------------------------------------------------



ql/src/test/queries/clientpositive/dynamic_rdd_cache.q (line 100)
<https://reviews.apache.org/r/36475/#comment145347>

    Nit: it seems we have a trailing space here.



ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java (line 223)
<https://reviews.apache.org/r/36475/#comment145345>

    Nit: maybe we should return an empty map instead.


- Xuefu Zhang


On July 15, 2015, 6:59 a.m., chengxiang li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36475/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 6:59 a.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-11082
>     https://issues.apache.org/jira/browse/HIVE-11082
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA description.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java 762f734 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/OperatorComparatorFactory.java 3518823

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/CombineEquivalentWorkResolver.java
b7c57e8 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 37012b4 
>   ql/src/test/queries/clientpositive/dynamic_rdd_cache.q a380b15 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out bc716a0 
>   ql/src/test/results/clientpositive/spark/auto_sortmerge_join_10.q.out 90085a8 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out 505cc59 
>   ql/src/test/results/clientpositive/spark/skewjoinopt9.q.out 155515d 
>   ql/src/test/results/clientpositive/spark/union15.q.out 6be13c9 
>   ql/src/test/results/clientpositive/spark/union16.q.out 5e2c77b 
>   ql/src/test/results/clientpositive/spark/union2.q.out e4afb1b 
>   ql/src/test/results/clientpositive/spark/union25.q.out 5193c06 
>   ql/src/test/results/clientpositive/spark/union9.q.out d420ef1 
> 
> Diff: https://reviews.apache.org/r/36475/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> chengxiang li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message