hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 36335: Reset the fields in class JoinStatsRule in StatsRulesProcFactory
Date Thu, 09 Jul 2015 19:44:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36335/#review91173
-----------------------------------------------------------

Ship it!


Ship It!

- John Pullokkaran


On July 8, 2015, 11:37 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36335/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 11:37 p.m.)
> 
> 
> Review request for hive, John Pullokkaran and Mostafa Mokhtar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried
on in between different calls. It would be better to move it inside the function, just like
all the other StatsRuls do.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
0982059 
> 
> Diff: https://reviews.apache.org/r/36335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message