hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cheng xu" <cheng.a...@intel.com>
Subject Re: Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
Date Wed, 08 Jul 2015 13:56:12 GMT


> On July 8, 2015, 9:27 p.m., Xuefu Zhang wrote:
> > beeline/src/java/org/apache/hive/beeline/Commands.java, line 759
> > <https://reviews.apache.org/r/36300/diff/1/?file=1002091#file1002091line759>
> >
> >     Why do we provide two way to do the same thing? When do we choose to use one
or the other?

This part of code is very tricky and blocked me quite some time. If you use the call method,
seems data is not synchronized with the server side. And if you use the sql method, it will
override the console of the beeline. I referred the code logic from executeInternal method.
To be honest, I am not quite follow the original purpose of this code logic but it works.


- cheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36300/#review90889
-----------------------------------------------------------


On July 8, 2015, 4:44 p.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36300/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 4:44 p.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-11191
>     https://issues.apache.org/jira/browse/HIVE-11191
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Summary:
> 1. Add option update stage after connection established in CLI mode
> 2. Update the getHiveConf API
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 1d468eb 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a 
>   beeline/src/java/org/apache/hive/beeline/Commands.java d490273 
>   beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 
> 
> Diff: https://reviews.apache.org/r/36300/diff/
> 
> 
> Testing
> -------
> 
> Partial UT passed and local cluster test passed.
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message