hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
Date Wed, 08 Jul 2015 13:27:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36300/#review90889
-----------------------------------------------------------



beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java (line 228)
<https://reviews.apache.org/r/36300/#comment144056>

    Since we are getting configurations when connection is first made, we should probably
store them for later use so that we don't need to make another again.



beeline/src/java/org/apache/hive/beeline/Commands.java (line 759)
<https://reviews.apache.org/r/36300/#comment144054>

    Why do we provide two way to do the same thing? When do we choose to use one or the other?


- Xuefu Zhang


On July 8, 2015, 8:44 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36300/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 8:44 a.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-11191
>     https://issues.apache.org/jira/browse/HIVE-11191
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Summary:
> 1. Add option update stage after connection established in CLI mode
> 2. Update the getHiveConf API
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 1d468eb 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a 
>   beeline/src/java/org/apache/hive/beeline/Commands.java d490273 
>   beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 
> 
> Diff: https://reviews.apache.org/r/36300/diff/
> 
> 
> Testing
> -------
> 
> Partial UT passed and local cluster test passed.
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message