hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 36069: HIVE-11141 : Improve RuleRegExp when the Expression node stack gets huge
Date Tue, 07 Jul 2015 19:09:46 GMT


> On July 7, 2015, 6:12 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java, line 52
> > <https://reviews.apache.org/r/36069/diff/2/?file=997802#file997802line52>
> >
> >     I dont clearly understand what you suggested, but I can assure that the implementation
here wont take much time in worst cases.

Currently for each patter char we are traversing the whole string. Instead create a hashset
of wild chars (static) then for each char in the rule string do a lookup to see if it exists
in the wild char set.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36069/#review90748
-----------------------------------------------------------


On July 7, 2015, 6:12 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36069/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 6:12 p.m.)
> 
> 
> Review request for hive, John Pullokkaran and Mostafa Mokhtar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Improve RuleRegExp when the Expression node stack gets huge
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java ddc96c2 
>   ql/src/test/org/apache/hadoop/hive/ql/lib/TestRuleRegExp.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36069/diff/
> 
> 
> Testing
> -------
> 
> Local testing.
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message