hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aihua Xu" <...@cloudera.com>
Subject Re: Review Request 36139: HIVE-11130 Refactoring the code so that HiveTxnManager interface will support lock/unlock table/database object
Date Thu, 02 Jul 2015 20:27:30 GMT


> On July 2, 2015, 5:36 p.m., Chao Sun wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java, line 174
> > <https://reviews.apache.org/r/36139/diff/1/?file=998352#file998352line174>
> >
> >     this looks exactly the same as DDLTask#getHiveObject. Is there a way to get
rid of the latter?

Moved to HiveLockObject as a static method so that it can be used by both.


- Aihua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36139/#review90252
-----------------------------------------------------------


On July 2, 2015, 5:24 p.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36139/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 5:24 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-11130 Refactoring the code so that HiveTxnManager interface will support lock/unlock
table/database object
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 8bcf860d1f4b783352e84c3b9c988e061ab0b751

>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManager.java 2dd0c7df2a91c7e9f7e8b9825725ccddd463262b

>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java eccb8d1d5ae7a41f90800fe8d62875978c98b074

> 
> Diff: https://reviews.apache.org/r/36139/diff/
> 
> 
> Testing
> -------
> 
> Test has been done. This work will be followed by HIVE-10984 to solve the explicit lock
table issue.
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message