Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38ABF1891D for ; Mon, 29 Jun 2015 16:55:47 +0000 (UTC) Received: (qmail 53818 invoked by uid 500); 29 Jun 2015 16:55:46 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 53747 invoked by uid 500); 29 Jun 2015 16:55:46 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 53734 invoked by uid 99); 29 Jun 2015 16:55:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jun 2015 16:55:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B379CABED5; Mon, 29 Jun 2015 16:55:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8225496189675803976==" MIME-Version: 1.0 Subject: Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources From: "Chaoyu Tang" To: "Aihua Xu" , "hive" , "Chaoyu Tang" Date: Mon, 29 Jun 2015 16:55:44 -0000 Message-ID: <20150629165544.13307.30540@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Chaoyu Tang" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35803/ X-Sender: "Chaoyu Tang" References: <20150626172317.3114.82568@reviews.apache.org> In-Reply-To: <20150626172317.3114.82568@reviews.apache.org> Reply-To: "Chaoyu Tang" X-ReviewRequest-Repository: hive-git --===============8225496189675803976== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803/#review89749 ----------------------------------------------------------- metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 1059) Indentation ... metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 1089) Indentation.. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 1788) Have you looked at MetaStoreDirectSql class to see if there is any potential query leaking? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3409) Do we have to use a list of queryWrappers with each wrapper for a different listXXX call? If so, we need open eight queries for this removeRole methods. Could we use only one and reuse it? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3417) Should listPrincipalGlobalGrants be passed in a queryWrapper as well? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 4765) Is there any reason you need an additional list to hold the retrieved result? - Chaoyu Tang On June 26, 2015, 5:23 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35803/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 5:23 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 417ecc8 > metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java d0ff329 > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java PRE-CREATION > > Diff: https://reviews.apache.org/r/35803/diff/ > > > Testing > ------- > > Testing has been done. > > > Thanks, > > Aihua Xu > > --===============8225496189675803976==--