Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C2A0218238 for ; Fri, 26 Jun 2015 22:58:14 +0000 (UTC) Received: (qmail 82501 invoked by uid 500); 26 Jun 2015 22:58:14 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 82428 invoked by uid 500); 26 Jun 2015 22:58:14 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 82406 invoked by uid 99); 26 Jun 2015 22:58:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2015 22:58:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C7392AB8E4; Fri, 26 Jun 2015 22:58:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4704026918693960959==" MIME-Version: 1.0 Subject: Review Request 35950: HIVE-11131: Get row information on DataWritableWriter once for better writing performance From: "Sergio Pena" To: "cheng xu" , "Dong Chen" , "Ryan Blue" Cc: "hive" , "Sergio Pena" Date: Fri, 26 Jun 2015 22:58:12 -0000 Message-ID: <20150626225812.20383.64301@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sergio Pena" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35950/ X-Sender: "Sergio Pena" Reply-To: "Sergio Pena" X-ReviewRequest-Repository: hive-git --===============4704026918693960959== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35950/ ----------------------------------------------------------- Review request for hive, Ryan Blue, cheng xu, and Dong Chen. Bugs: HIVE-11131 https://issues.apache.org/jira/browse/HIVE-11131 Repository: hive-git Description ------- Implemented data type writers that will be created before the first Hive row is written to Parquet. These writers contain information about object inspectors and schema of a specific data type, and calls the specific addXXXX() method used by Parquet for each data type. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriter.java c195c3ec3ddae19bf255fc2c9633f8bf4390f428 Diff: https://reviews.apache.org/r/35950/diff/ Testing ------- Tests from TestDataWritableWriter run OK. I run other tests with micro-becnhmarks, and I got some better results from this new implemntation: Using repeated rows across the file, the speed increased in: bigint boolean double float int string 33.42% 53.66% 35.62% 35.70% 36.02% 5.93% Using random rows across the file, the speed increased in: bigint boolean double float int string 18.38% 35.52% 44.73% 13.80% 10.68% 10.00% Thanks, Sergio Pena --===============4704026918693960959==--