hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nishant Kelkar" <nishant....@gmail.com>
Subject Re: Review Request 35968: 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration tests. 3. Registered the UDF in the FunctionRegistry class.
Date Sun, 28 Jun 2015 11:23:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35968/#review89646
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCosineSimilarity.java (line 4)
<https://reviews.apache.org/r/35968/#comment142310>

    Hey Alexander,
    
    I found the following in the ~hive/ql/pom.xml:
    
        <dependency>
           <groupId>org.apache.commons</groupId>
           <artifactId>commons-lang3</artifactId>
           <version>${commons-lang3.version}</version>
        </dependency>
    Looks like we have this dependency?



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCosineSimilarity.java (line 93)
<https://reviews.apache.org/r/35968/#comment142311>

    Oh, I use Java 1.7, so I don't need to mention HashSet<String>. But I'll probably
need to, to be backwards compatible with people compiling with Java 1.6.



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCosineSimilarity.java (line 109)
<https://reviews.apache.org/r/35968/#comment142320>

    Do we usually log such edge cases in Hive? If yes, I could add a slf4j logger to this
UDF.


- Nishant Kelkar


On June 28, 2015, 11:22 a.m., Nishant Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35968/
> -----------------------------------------------------------
> 
> (Updated June 28, 2015, 11:22 a.m.)
> 
> 
> Review request for hive and Alexander Pivovarov.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> 1. Added preliminary UDF code for cosine similarity. 2. Added unit tests and integration
tests. 3. Registered the UDF in the FunctionRegistry class.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc abc33f91a44b76573cbba334c33417307c63956f 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fabc21e2092561cbf98c35a406e4ee40e71fe1de

>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCosineSimilarity.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFCosineSimilarity.java PRE-CREATION

>   ql/src/test/queries/clientnegative/udf_cosine_similarity_error_1.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_cosine_similarity_wrongargs_1.q PRE-CREATION

>   ql/src/test/queries/clientnegative/udf_cosine_similarity_wrongargs_2.q PRE-CREATION

>   ql/src/test/queries/clientnegative/udf_cosine_similarity_wrongargs_3.q PRE-CREATION

>   ql/src/test/queries/clientpositive/udf_cosine_similarity.q PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_cosine_similarity_error_1.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/udf_cosine_similarity_error_2.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/udf_cosine_similarity_wrongargs_1.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/udf_cosine_similarity_wrongargs_2.q.out PRE-CREATION

>   ql/src/test/results/clientnegative/udf_cosine_similarity_wrongargs_3.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3

>   ql/src/test/results/clientpositive/udf_cosine_similarity.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35968/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nishant Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message