hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 35618: HiveOnTez: make explain user level = true as default
Date Fri, 19 Jun 2015 19:02:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35618/#review88570
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java (line 153)
<https://reviews.apache.org/r/35618/#comment141146>

    Who closes the printstream?
    Is it managed by ExplainTask?


- John Pullokkaran


On June 19, 2015, 1:38 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35618/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 1:38 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> In Hive-9780, we introduced a new level of explain for hive on tez. We would like to
make it running by default.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java fb12f70 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/PrintUtils.java PRE-CREATION

>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 10e0a0c 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java 43ddff3

>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java 9b3405e 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 27f68df 
>   itests/src/test/resources/testconfiguration.properties b9f39fb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 35c4cfc 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 3fbc8de 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalWork.java 7a561e6 
>   ql/src/test/queries/clientpositive/explainuser_3.q PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/auto_join0.q.out beaac17 
>   ql/src/test/results/clientpositive/tez/auto_join1.q.out 41cbcc7 
>   ql/src/test/results/clientpositive/tez/auto_join21.q.out ca60448 
>   ql/src/test/results/clientpositive/tez/auto_join29.q.out 18c07d9 
>   ql/src/test/results/clientpositive/tez/auto_join30.q.out 8c20985 
>   ql/src/test/results/clientpositive/tez/auto_sortmerge_join_10.q.out 7194be5 
>   ql/src/test/results/clientpositive/tez/auto_sortmerge_join_13.q.out c0f99cc 
>   ql/src/test/results/clientpositive/tez/auto_sortmerge_join_14.q.out 81b6fe6 
>   ql/src/test/results/clientpositive/tez/auto_sortmerge_join_15.q.out 5e30dff 
>   ql/src/test/results/clientpositive/tez/auto_sortmerge_join_9.q.out 9f3e698 
>   ql/src/test/results/clientpositive/tez/bucket2.q.out 55aa220 
>   ql/src/test/results/clientpositive/tez/bucket3.q.out bbd9c67 
>   ql/src/test/results/clientpositive/tez/bucket4.q.out ed8671c 
>   ql/src/test/results/clientpositive/tez/bucket_map_join_tez1.q.out 61c197f 
>   ql/src/test/results/clientpositive/tez/bucket_map_join_tez2.q.out 3f980b6 
>   ql/src/test/results/clientpositive/tez/correlationoptimizer1.q.out 444f931 
>   ql/src/test/results/clientpositive/tez/count.q.out a5e6082 
>   ql/src/test/results/clientpositive/tez/cross_join.q.out 30564d7 
>   ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out 35c4ea8 
>   ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out 14dd820 
>   ql/src/test/results/clientpositive/tez/ctas.q.out 5e9aee2 
>   ql/src/test/results/clientpositive/tez/disable_merge_for_bucketing.q.out 84e0d2c 
>   ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out cd2de52 
>   ql/src/test/results/clientpositive/tez/dynamic_partition_pruning_2.q.out c8e9da4 
>   ql/src/test/results/clientpositive/tez/dynpart_sort_opt_vectorization.q.out 04927b8

>   ql/src/test/results/clientpositive/tez/dynpart_sort_optimization.q.out 8a16645 
>   ql/src/test/results/clientpositive/tez/dynpart_sort_optimization2.q.out 6b6d912 
>   ql/src/test/results/clientpositive/tez/explainuser_1.q.out d39da20 
>   ql/src/test/results/clientpositive/tez/explainuser_2.q.out 222e89e 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/groupby1.q.out 010ad5f 
>   ql/src/test/results/clientpositive/tez/groupby2.q.out dcf6806 
>   ql/src/test/results/clientpositive/tez/groupby3.q.out 72799d5 
>   ql/src/test/results/clientpositive/tez/having.q.out 6fc60d5 
>   ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_1.q.out 4b39b2c 
>   ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_2.q.out 737bd1d 
>   ql/src/test/results/clientpositive/tez/insert_into1.q.out 3d576a4 
>   ql/src/test/results/clientpositive/tez/insert_into2.q.out 2c7ec63 
>   ql/src/test/results/clientpositive/tez/join0.q.java1.7.out cceefb2 
>   ql/src/test/results/clientpositive/tez/join1.q.out c5bd100 
>   ql/src/test/results/clientpositive/tez/join_nullsafe.q.out 79ee3f0 
>   ql/src/test/results/clientpositive/tez/limit_pushdown.q.out 2a41aae 
>   ql/src/test/results/clientpositive/tez/load_dyn_part1.q.out dcf011e 
>   ql/src/test/results/clientpositive/tez/load_dyn_part2.q.out 1c0472f 
>   ql/src/test/results/clientpositive/tez/load_dyn_part3.q.out 8f95a76 
>   ql/src/test/results/clientpositive/tez/lvj_mapjoin.q.out 0a6be5f 
>   ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 7ca537d 
>   ql/src/test/results/clientpositive/tez/mapjoin_mapjoin.q.out f2610de 
>   ql/src/test/results/clientpositive/tez/mapreduce1.q.out cdf7d55 
>   ql/src/test/results/clientpositive/tez/mapreduce2.q.out 06c56d6 
>   ql/src/test/results/clientpositive/tez/merge1.q.out b321080 
>   ql/src/test/results/clientpositive/tez/merge2.q.out d7be565 
>   ql/src/test/results/clientpositive/tez/mergejoin.q.out c4be404 
>   ql/src/test/results/clientpositive/tez/metadata_only_queries.q.out aaea52e 
>   ql/src/test/results/clientpositive/tez/mrr.q.out d42f9b0 
>   ql/src/test/results/clientpositive/tez/orc_merge1.q.out 77ea36a 
>   ql/src/test/results/clientpositive/tez/orc_merge2.q.out 4eb1a0f 
>   ql/src/test/results/clientpositive/tez/orc_merge3.q.out 195e176 
>   ql/src/test/results/clientpositive/tez/orc_merge4.q.out a902fc6 
>   ql/src/test/results/clientpositive/tez/orc_merge5.q.out c2d841e 
>   ql/src/test/results/clientpositive/tez/orc_merge6.q.out 73bb4a7 
>   ql/src/test/results/clientpositive/tez/orc_merge7.q.out c972288 
>   ql/src/test/results/clientpositive/tez/orc_merge_incompat1.q.out ea2dd5d 
>   ql/src/test/results/clientpositive/tez/orc_merge_incompat2.q.out 52997c0 
>   ql/src/test/results/clientpositive/tez/parallel.q.out 238b860 
>   ql/src/test/results/clientpositive/tez/ptf.q.out b4b7a4b 
>   ql/src/test/results/clientpositive/tez/ptf_matchpath.q.out 3a2071d 
>   ql/src/test/results/clientpositive/tez/ptf_streaming.q.out 2b37c1b 
>   ql/src/test/results/clientpositive/tez/script_pipe.q.out fb95cbc 
>   ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out 59c8f2a 
>   ql/src/test/results/clientpositive/tez/select_dummy_source.q.out fa99b76 
>   ql/src/test/results/clientpositive/tez/skewjoin.q.out ec368f9 
>   ql/src/test/results/clientpositive/tez/stats_noscan_1.q.out aa49526 
>   ql/src/test/results/clientpositive/tez/stats_only_null.q.out 2725be0 
>   ql/src/test/results/clientpositive/tez/subquery_exists.q.out 503a5e9 
>   ql/src/test/results/clientpositive/tez/subquery_in.q.out 38f4bc6 
>   ql/src/test/results/clientpositive/tez/temp_table.q.out 49f57c2 
>   ql/src/test/results/clientpositive/tez/tez_bmj_schema_evolution.q.out b31a403 
>   ql/src/test/results/clientpositive/tez/tez_dml.q.out ae85292 
>   ql/src/test/results/clientpositive/tez/tez_join.q.out 7b22996 
>   ql/src/test/results/clientpositive/tez/tez_join_hash.q.out 59c8df4 
>   ql/src/test/results/clientpositive/tez/tez_join_tests.q.out 88523dc 
>   ql/src/test/results/clientpositive/tez/tez_joins_explain.q.out 31f7275 
>   ql/src/test/results/clientpositive/tez/tez_smb_1.q.out e60d5af 
>   ql/src/test/results/clientpositive/tez/tez_smb_main.q.out 52e1750 
>   ql/src/test/results/clientpositive/tez/tez_union.q.out 4012b90 
>   ql/src/test/results/clientpositive/tez/tez_union2.q.out 4c7f5f9 
>   ql/src/test/results/clientpositive/tez/tez_union_dynamic_partition.q.out 68a7531 
>   ql/src/test/results/clientpositive/tez/tez_union_group_by.q.out 6f18c96 
>   ql/src/test/results/clientpositive/tez/tez_union_multiinsert.q.out 132f859 
>   ql/src/test/results/clientpositive/tez/transform1.q.out 49d2a5c 
>   ql/src/test/results/clientpositive/tez/union2.q.out c127089 
>   ql/src/test/results/clientpositive/tez/union3.q.out 1a9feed 
>   ql/src/test/results/clientpositive/tez/union4.q.out 9d079ad 
>   ql/src/test/results/clientpositive/tez/union5.q.out 327195c 
>   ql/src/test/results/clientpositive/tez/union6.q.out 4647278 
>   ql/src/test/results/clientpositive/tez/union7.q.out c5ece62 
>   ql/src/test/results/clientpositive/tez/union8.q.out 6ae1dff 
>   ql/src/test/results/clientpositive/tez/union9.q.out ee26daf 
>   ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out 3d04de9 
>   ql/src/test/results/clientpositive/tez/vector_aggregate_9.q.out 382380e 
>   ql/src/test/results/clientpositive/tez/vector_between_in.q.out 61e215e 
>   ql/src/test/results/clientpositive/tez/vector_binary_join_groupby.q.out 8dcd40d 
>   ql/src/test/results/clientpositive/tez/vector_bucket.q.out eab698c 
>   ql/src/test/results/clientpositive/tez/vector_cast_constant.q.java1.7.out c700038 
>   ql/src/test/results/clientpositive/tez/vector_char_2.q.out 4a2b795 
>   ql/src/test/results/clientpositive/tez/vector_char_4.q.out 8daf377 
>   ql/src/test/results/clientpositive/tez/vector_char_mapjoin1.q.out f495f95 
>   ql/src/test/results/clientpositive/tez/vector_char_simple.q.out 9c72edb 
>   ql/src/test/results/clientpositive/tez/vector_coalesce.q.out c787ce9 
>   ql/src/test/results/clientpositive/tez/vector_coalesce_2.q.out a43303f 
>   ql/src/test/results/clientpositive/tez/vector_count_distinct.q.out e6d34ff 
>   ql/src/test/results/clientpositive/tez/vector_data_types.q.out 972404b 
>   ql/src/test/results/clientpositive/tez/vector_date_1.q.out aac10c0 
>   ql/src/test/results/clientpositive/tez/vector_decimal_1.q.out 58c107a 
>   ql/src/test/results/clientpositive/tez/vector_decimal_10_0.q.out a682a8e 
>   ql/src/test/results/clientpositive/tez/vector_decimal_2.q.out bbdd75f 
>   ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 2e9c232 
>   ql/src/test/results/clientpositive/tez/vector_decimal_cast.q.out 59b80f2 
>   ql/src/test/results/clientpositive/tez/vector_decimal_expressions.q.out b834985 
>   ql/src/test/results/clientpositive/tez/vector_decimal_mapjoin.q.out 240b875 
>   ql/src/test/results/clientpositive/tez/vector_decimal_math_funcs.q.out 5e85b63 
>   ql/src/test/results/clientpositive/tez/vector_decimal_precision.q.out 4e1b654 
>   ql/src/test/results/clientpositive/tez/vector_decimal_round.q.out 9ea95b9 
>   ql/src/test/results/clientpositive/tez/vector_decimal_round_2.q.out 103fd8a 
>   ql/src/test/results/clientpositive/tez/vector_decimal_udf.q.out b24ebcc 
>   ql/src/test/results/clientpositive/tez/vector_decimal_udf2.q.out 1496a5f 
>   ql/src/test/results/clientpositive/tez/vector_distinct_2.q.out 1671ddf 
>   ql/src/test/results/clientpositive/tez/vector_elt.q.out bb66867 
>   ql/src/test/results/clientpositive/tez/vector_groupby_3.q.out 9b9dcdd 
>   ql/src/test/results/clientpositive/tez/vector_groupby_reduce.q.out 637bb3b 
>   ql/src/test/results/clientpositive/tez/vector_grouping_sets.q.out 688d2ac 
>   ql/src/test/results/clientpositive/tez/vector_if_expr.q.out d1ed01c 
>   ql/src/test/results/clientpositive/tez/vector_inner_join.q.out af80260 
>   ql/src/test/results/clientpositive/tez/vector_interval_1.q.out 1cc7cb6 
>   ql/src/test/results/clientpositive/tez/vector_interval_2.q.out 64f5b28 
>   ql/src/test/results/clientpositive/tez/vector_interval_mapjoin.q.out b4d3477 
>   ql/src/test/results/clientpositive/tez/vector_join30.q.out 2a14842 
>   ql/src/test/results/clientpositive/tez/vector_left_outer_join.q.out ce722e8 
>   ql/src/test/results/clientpositive/tez/vector_left_outer_join2.q.out 6c781e3 
>   ql/src/test/results/clientpositive/tez/vector_leftsemi_mapjoin.q.out 6e4971d 
>   ql/src/test/results/clientpositive/tez/vector_mapjoin_reduce.q.out 29b86bd 
>   ql/src/test/results/clientpositive/tez/vector_mr_diff_schema_alias.q.out c53f0c4 
>   ql/src/test/results/clientpositive/tez/vector_multi_insert.q.out 1080bf4 
>   ql/src/test/results/clientpositive/tez/vector_non_string_partition.q.out 9b7e8f6 
>   ql/src/test/results/clientpositive/tez/vector_null_projection.q.out 88587e9 
>   ql/src/test/results/clientpositive/tez/vector_nullsafe_join.q.out db170a9 
>   ql/src/test/results/clientpositive/tez/vector_orderby_5.q.out af15925 
>   ql/src/test/results/clientpositive/tez/vector_outer_join0.q.out d1ee177 
>   ql/src/test/results/clientpositive/tez/vector_outer_join1.q.out 95ed151 
>   ql/src/test/results/clientpositive/tez/vector_outer_join2.q.out 31ef469 
>   ql/src/test/results/clientpositive/tez/vector_outer_join3.q.out 75c4215 
>   ql/src/test/results/clientpositive/tez/vector_outer_join4.q.out 2c9a9cd 
>   ql/src/test/results/clientpositive/tez/vector_outer_join5.q.out e77903a 
>   ql/src/test/results/clientpositive/tez/vector_partition_diff_num_cols.q.out 65b2ff1

>   ql/src/test/results/clientpositive/tez/vector_partitioned_date_time.q.out 159c5a7 
>   ql/src/test/results/clientpositive/tez/vector_reduce_groupby_decimal.q.out 528c2cb

>   ql/src/test/results/clientpositive/tez/vector_string_concat.q.out f6eb9c5 
>   ql/src/test/results/clientpositive/tez/vector_varchar_4.q.out 02fa042 
>   ql/src/test/results/clientpositive/tez/vector_varchar_mapjoin1.q.out ae5be44 
>   ql/src/test/results/clientpositive/tez/vector_varchar_simple.q.out e90eefa 
>   ql/src/test/results/clientpositive/tez/vectorization_0.q.out 250f3d3 
>   ql/src/test/results/clientpositive/tez/vectorization_13.q.out 55a68c2 
>   ql/src/test/results/clientpositive/tez/vectorization_14.q.out cc2b6cc 
>   ql/src/test/results/clientpositive/tez/vectorization_15.q.out 779c37f 
>   ql/src/test/results/clientpositive/tez/vectorization_16.q.out bfed7d1 
>   ql/src/test/results/clientpositive/tez/vectorization_7.q.out 34f590d 
>   ql/src/test/results/clientpositive/tez/vectorization_8.q.out 912f5a7 
>   ql/src/test/results/clientpositive/tez/vectorization_9.q.out c0e9a3e 
>   ql/src/test/results/clientpositive/tez/vectorization_decimal_date.q.out c20033c 
>   ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 49dc346 
>   ql/src/test/results/clientpositive/tez/vectorization_limit.q.out 1c5b51f 
>   ql/src/test/results/clientpositive/tez/vectorization_part_project.q.out a5eabf8 
>   ql/src/test/results/clientpositive/tez/vectorization_pushdown.q.out e203bfd 
>   ql/src/test/results/clientpositive/tez/vectorization_short_regress.q.out 3cf898f 
>   ql/src/test/results/clientpositive/tez/vectorized_bucketmapjoin1.q.out 56ef3e2 
>   ql/src/test/results/clientpositive/tez/vectorized_case.q.out 7f824f1 
>   ql/src/test/results/clientpositive/tez/vectorized_casts.q.out c9992a6 
>   ql/src/test/results/clientpositive/tez/vectorized_context.q.out b2b71cd 
>   ql/src/test/results/clientpositive/tez/vectorized_date_funcs.q.out be782e4 
>   ql/src/test/results/clientpositive/tez/vectorized_distinct_gby.q.out 932b175 
>   ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out add8a65

>   ql/src/test/results/clientpositive/tez/vectorized_mapjoin.q.out 4430908 
>   ql/src/test/results/clientpositive/tez/vectorized_math_funcs.q.out 444b9e0 
>   ql/src/test/results/clientpositive/tez/vectorized_nested_mapjoin.q.out 01a36e5 
>   ql/src/test/results/clientpositive/tez/vectorized_parquet.q.out 8118139 
>   ql/src/test/results/clientpositive/tez/vectorized_shufflejoin.q.out 1fe15fe 
>   ql/src/test/results/clientpositive/tez/vectorized_string_funcs.q.out 0463d31 
>   ql/src/test/results/clientpositive/tez/vectorized_timestamp_funcs.q.out b285a4f 
> 
> Diff: https://reviews.apache.org/r/35618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message