hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 35576: HIVE-11028 Tez: table self join and join with another table fails with IndexOutOfBoundsException
Date Wed, 17 Jun 2015 19:39:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35576/#review88269
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java (line 46)
<https://reviews.apache.org/r/35576/#comment140696>

    As we discussed, Couldn't we move foldExpr from ConstantPropagate to ExprNodeDescUtils.
    
    Then DPP could use ExprNodeDescUtils directly without depending on ConstantProp.
    
    IMO, its a better seperation.


- John Pullokkaran


On June 17, 2015, 6:38 p.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35576/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 6:38 p.m.)
> 
> 
> Review request for hive, Gunther Hagleitner and John Pullokkaran.
> 
> 
> Bugs: HIVE-11028
>     https://issues.apache.org/jira/browse/HIVE-11028
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Change TezCompiler to only run short-cutting of expressions rather than full constant
folding.
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties b9f39fb 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java 0027960 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcCtx.java 6bb2a09

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java 4a4814d

>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 56707af 
>   ql/src/test/queries/clientpositive/tez_self_join.q PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/tez_self_join.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35576/diff/
> 
> 
> Testing
> -------
> 
> qfile test added
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message