hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <>
Subject Review Request 35181: HIVE-10944 : Fix HS2 for Metrics
Date Sat, 06 Jun 2015 22:18:18 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for hive and Sergey Shelukhin.

Repository: hive-git


Eliminated the redundant conf checks and eliminate synchronization in the code path, by making
the static Metrics instance as a static volatile variable.  Achieved this by removing the
Metrics init() method and moved directly to the constructor.

Left some of the synchronization in the old LegacyMetrics the same.


  common/src/java/org/apache/hadoop/hive/common/ c3949f2 
  common/src/java/org/apache/hadoop/hive/common/metrics/ 14f7afb 
  common/src/java/org/apache/hadoop/hive/common/metrics/common/ 13a5336 
  common/src/java/org/apache/hadoop/hive/common/metrics/common/ 12a309d

  common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ e59da99

  metastore/src/java/org/apache/hadoop/hive/metastore/ 85a734c 
  service/src/java/org/apache/hive/service/server/ 7820ed5 



Ran affected tests, ran HS2 with and without metrics enabled.


Szehon Ho

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message